-
Archives
- November 2011
- October 2011
- September 2011
- August 2011
- July 2011
- June 2011
- May 2011
- April 2011
- March 2011
- February 2011
- January 2011
- December 2010
- November 2010
- September 2010
- August 2010
- July 2010
- June 2010
- May 2010
- April 2010
- March 2010
- January 2010
- December 2009
- November 2009
- September 2009
- August 2009
- July 2009
- June 2009
- May 2009
- March 2009
- February 2009
- January 2009
- December 2008
- November 2008
- October 2008
- September 2008
- August 2008
- July 2008
- June 2008
- May 2008
- April 2008
- February 2008
- January 2008
- December 2007
- November 2007
- October 2007
- September 2007
- August 2007
- July 2007
- June 2007
- May 2007
- April 2007
- March 2007
- February 2007
- October 2006
- September 2006
- August 2006
- July 2006
- June 2006
- May 2006
- April 2006
- March 2006
- February 2006
- January 2006
- December 2005
- June 2005
-
Meta
Category Archives: code review
Code Review #3: Use the debugger to check “working” code
There is a bug (or two) in this code: protected void compareStreams(InputStream is, InputStream isFromGet) throws IOException { byte[] newBuf = new byte[4096]; byte[] oldBuf = new byte[4096]; int len = 0; while ((len = is.read(newBuf)) != -1) { boolean … Continue reading
Posted in code review, technical
Leave a comment
Code Review #2: “It ain’t stored until the database says it is”
This was a recent comment on a bug report: EventImpl stores start and end dates as two strings (milliseconds presentation of date). Not clearly understand how information can be lost. What is wrong with this statement? Well nothing is “stored” … Continue reading
Posted in code review, technical
Leave a comment
Code Review #1: Masking of Throwables
When it comes to finally blocks, extra care is required. The code within a finally block can make very few assumptions about the state of variables that it is dealing with. Usually where developers slip-up is with null handling. This … Continue reading
Posted in code review, technical
Leave a comment
Code Reviews
Sometimes a code review reveals a code problem that just keeps repeating itself again and again. So rather than creating new email messages I have decided to start posting some code reviews. This will allow me to avoid repeating myself. … Continue reading
Posted in code review, management, technical
Leave a comment
Thoughts on how to evaluate code
I met someone at Startup Camp2 who was non-techincal but had an idea that required technical expertise. She faced the typical problem of judging and evaluate software code in order to make sure the people she hired were: competent making … Continue reading
Posted in amplafi, code review, management, technical
5 Comments