-
Archives
- August 2010
- July 2010
- June 2010
- May 2010
- April 2010
- March 2010
- January 2010
- December 2009
- November 2009
- September 2009
- August 2009
- July 2009
- June 2009
- May 2009
- March 2009
- February 2009
- January 2009
- December 2008
- November 2008
- October 2008
- September 2008
- August 2008
- July 2008
- June 2008
- May 2008
- April 2008
- February 2008
- January 2008
- December 2007
- November 2007
- October 2007
- September 2007
- August 2007
- July 2007
- June 2007
- May 2007
- April 2007
- March 2007
- February 2007
- October 2006
- September 2006
- August 2006
- July 2006
- June 2006
- May 2006
- April 2006
- March 2006
- February 2006
- January 2006
- December 2005
- June 2005
-
Meta
Category Archives: code review
Code Review #8: When to comment
The last ? in a series of posts about commenting. See “the why”. See “not commenting is career threatening”. And the comment that started this off! This post should have really been the second one I wrote. The first post … Continue reading
Posted in code review, management
1 Comment
Why and when to wrap external library classes
At some point, every developer starts using an external library. They then have to decide if that external library should be wrapped in their own custom interfaces and classes. If the external library would be pervasively imported in throughout the … Continue reading
Posted in code review, hibernate, technical
Leave a comment
Interfaces vs. abstract classes
Sigh … some people just don’t get it…. Interfaces rock! Below is my comment from stackoverflow.com, a question about how to handle the “interfaces v. abstract classes” interview question in an interview. First, the “only one super class” answer is … Continue reading
Posted in code review, technical
Leave a comment
Code Review #7 – Comment the “why” not the “what”
[This post continues the response to Mike.] Clean “good” code is good but not enough. Code needs comments — but the right kind of comments. “What” comments are useless and the most quickly out-dated. An example of a what comment … Continue reading
Posted in code review, management, technical
6 Comments
Not commenting code is dangerous to your career
There is this myth that code can be self-documenting and that comments are not necessary in good code. Michael recently comment on an earlier blog post advocating the idea of self-documenting code. “Self-documenting” code is a career-damaging concept, because: Your … Continue reading
Posted in code review, management
3 Comments
Code Review #6 – ‘Too smart’ aka scared of being dumb
One of the biggest failing junior developers have is that they are too ‘smart’. ‘Too smart’??? How can someone be ‘too smart’? Actually pretty easily. ‘Too smart’ is when the person spent hours looking at a problem. And the next … Continue reading
Posted in code review, management, technical
1 Comment
Code Review #5 – splurge on reporting configuration errors
Configuration problems when deploying a new build are high on the “high anxiety” list. The pressure is high to hurry up and get the build deployed. Often times, the deploy happens late at night when the deployer really just wants … Continue reading
Posted in code review, technical
Leave a comment
Code Review #4: Always read the documentation/code – a.k.a. java.net.URL is evil
The Setup Before I plunge into my rant, lets review a little-ole documentation. Under java.lang.Object, for equals() we have this: It is consistent: for any non-null reference values x and y, multiple invocations of x.equals(y) consistently return true or consistently … Continue reading
Posted in code review, technical
5 Comments
Code Review #3: Use the debugger to check “working” code
There is a bug (or two) in this code: protected void compareStreams(InputStream is, InputStream isFromGet) throws IOException { byte[] newBuf = new byte[4096]; byte[] oldBuf = new byte[4096]; int len = 0; while ((len = is.read(newBuf)) != -1) { boolean … Continue reading
Posted in code review, technical
Leave a comment
Code Review #2: “It ain’t stored until the database says it is”
This was a recent comment on a bug report: EventImpl stores start and end dates as two strings (milliseconds presentation of date). Not clearly understand how information can be lost. What is wrong with this statement? Well nothing is “stored” … Continue reading
Posted in code review, technical
Leave a comment